Skip to content

Minor CMake code review#300

Merged
walbourn merged 3 commits intomainfrom
cmakecr
May 6, 2026
Merged

Minor CMake code review#300
walbourn merged 3 commits intomainfrom
cmakecr

Conversation

@walbourn
Copy link
Copy Markdown
Member

@walbourn walbourn commented May 6, 2026

  • CMake 3.21+ allows removal of JoinPaths.cmake helper.
  • Added download failure message to BUILD_SHMATH on non-Win32 targets
  • Added CMP0162 for proper UseDebugLibraries behavior with VS generators
  • In CMake 4.1, the VS Generator no longer adds /Zc:forScope /Zc:inline /Zc:wchar_t to compiler unless listed in the Cmake--only impacts SHMath feature in any case

@walbourn walbourn self-assigned this May 6, 2026
@walbourn walbourn merged commit 4dc9bc2 into main May 6, 2026
224 checks passed
@walbourn walbourn deleted the cmakecr branch May 6, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants